Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct python package installation on Dockerfiles #2362

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

ssbarnea
Copy link
Member

This should fix failures with CentOS 8.

@decentral1se
Copy link
Contributor

decentral1se commented Oct 11, 2019

Restarted the failed build (unrelated).

Wanna test it by toggling TEST_CENTOS_VERSION (see tox.ini)?

We could just use =8 if we can support it like this.

@ssbarnea
Copy link
Member Author

Restarted the failed build (unrelated).

Wanna test it by toggling TEST_CENTOS_VERSION (see tox.ini)?

We could just use =8 if we can support it like this.

I tested manually. I plan to add a special job that tests the Dockerfile on multiple platforms but it would be outside the scope of this fix.

Copy link
Contributor

@decentral1se decentral1se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well OK then. I didn't test this myself.

@ssbarnea ssbarnea merged commit bc6414f into ansible:master Oct 11, 2019
@ssbarnea ssbarnea added the bug label Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants