Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hetzner Cloud driver from core #2391

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

decentral1se
Copy link
Contributor

@ssbarnea ssbarnea added test Improvement to quality assurance: CI/CD, testing, building driver-podman labels Oct 23, 2019
@decentral1se decentral1se added driver-hetznercloud and removed driver-podman test Improvement to quality assurance: CI/CD, testing, building labels Oct 23, 2019
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that I cannot say no to reviews that are removing code.

@ssbarnea ssbarnea changed the title Remove Hetzner Cloud driver (will be a plugin) Remove Hetzner Cloud driver from core Oct 23, 2019
@ssbarnea ssbarnea added the major label Oct 23, 2019
@ssbarnea ssbarnea added this to the 3.0 milestone Oct 23, 2019
@ssbarnea ssbarnea merged commit f1003cb into ansible:master Oct 23, 2019
@decentral1se decentral1se deleted the remove-hetzner-driver branch October 24, 2019 08:44
@till
Copy link

till commented Nov 15, 2019

@decentral1se How do you use this with head? Now:

ERROR: Failed to validate.

{'driver': [{'name': ['unallowed value hetznercloud']}]}

Dockerfile:

FROM quay.io/ansible/molecule:latest
RUN apk add --update build-base git
RUN pip install --upgrade pip
RUN pip install dnspython requests==2.20.1 docker docker-compose hcloud molecule[hetznercloud]
RUN pip install git+https://github.com/pycontribs/molecule-hetznercloud.git@master#egg=molecule-hetznercloud

@decentral1se
Copy link
Contributor Author

Hey @till, sorry you ran into so many issues. We're in a transition period now and I shouldn't have recommended this approach. At current state, you should pip install -e . the molecule source and then run the pip install git+https://github.com/pycontribs/molecule-hetznercloud.git@master#egg=molecule-hetznercloud command but I've done that now and found another few issues. I better go raise those tickets 😅

@ssbarnea
Copy link
Member

As drivers can request their minimal version of molecule needed, including prerelease, it would be easier to document “pip install molecule-drivername” as the way to install them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants