lint refresh #2436
Merged
lint refresh #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for avoiding a false positive of: [BLK100] Black would make changes.
|
closed/reopen to try and tick Travis-CI back into life |
ssbarnea
requested review from
LukeShortCloud,
cloudnull,
abadger and
sshnaidm
sshnaidm
reviewed
Nov 13, 2019
ssbarnea
added
test
ssbarnea
commented
Nov 13, 2019
sshnaidm
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for avoiding a false positive of:
This was happening because flake8-black adopted new format of black but we were using an older version of black. They need to be kept in sync in order to avoid such errors. Arguably we could even remove flake8-black in the future because we always run black anyway.