tests: use is_subset to validate loaded data #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
added
test
ssbarnea
requested review from
cloudnull,
decentral1se,
sshnaidm and
themr0c
cloudnull
suggested changes
Jan 3, 2020
ssbarnea
force-pushed
the
fix/is_subset
branch
from
43fc6d9
to
583200a
Compare
ssbarnea
force-pushed
the
fix/is_subset
branch
from
583200a
to
ed04a3b
Compare
Fixes recurring problem with tests which failed for users that use DOCKER_HOST to point to a remote docker. This happened because in those cases the loaded configuration dictionary looks different as it has extra parameters added to it. We failed to catch these on CI because we do not use a remote docker connection. From now on we should only check specific content in loaded config. Also includes fixing of absolute imports with regression prevention measure.
ssbarnea
force-pushed
the
fix/is_subset
branch
from
ed04a3b
to
b100dbd
Compare
cloudnull
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes recurring problem with tests which failed for users that use
DOCKER_HOSTto point to a remote docker. This happened because in those cases the loaded configuration dictionary looks different as it has extra parameters added to it.We failed to catch these on CI because we do not use a remote docker connection.