test: detect broken podman #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
added
test
sshnaidm
suggested changes
Jan 5, 2020
molecule/test/functional/conftest.py
Outdated
| def get_virtualbox_executable(): | ||
| return distutils.spawn.find_executable('VBoxManage') | ||
|
|
||
|
|
||
| @pytest.helpers.register | ||
| @util.lru_cache |
There was a problem hiding this comment.
is this related to the commit?
molecule/test/functional/conftest.py
Outdated
| podman = get_podman_executable() | ||
| if podman: | ||
| result = util.run([podman, "info"], stdout=PIPE, universal_newlines=True) | ||
| if result.returncode != 0: |
There was a problem hiding this comment.
I'd rather use failfast here instead of nested if/if/if but not critical.
Improved podman detection so we fail fast if current installation does not pass `podman info` minimal test. This should save time running tests on systems what are not properly configured. Skips will happen only on platforms that are known not to support podman, but on those supporting it, tests will fail. Enables lru_cache on podman/docker checks in order to improve testing runtime performance.
sshnaidm
approved these changes
Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved podman detection so we fail fast if current installation does
not pass
podman infominimal test. This should save time runningtests on systems what are not properly configured.
Skips will happen only on platforms that are known not to support
podman, but on those supporting it, tests will fail.
Enables
lru_cacheon podman/docker checks in order to improvetesting runtime performance.
I faced containers/podman#4665 on a RHEL 8 where: