Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid breaking pytest collection with testinfra #2555

Merged
merged 1 commit into from
Feb 15, 2020
Merged

Avoid breaking pytest collection with testinfra #2555

merged 1 commit into from
Feb 15, 2020

Conversation

ssbarnea
Copy link
Member

Updates testinfra cookiecutter template with code that skips the tests
when run outside molecule or when testinfra is not installed.

This would prevent breaking other usages of pytest, including collection,
when creating a new role inside a repository that already had tests.

Fixes: #2528

@ssbarnea
Avoid breaking pytest collection with testinfra
c75519e 
Updates testinfra cookiecutter template with code that skips the tests
when run outside molecule or when testinfra is not installed.

This would prevent breaking other usages of pytest, including collection,
when creating a new role inside a repository that already had tests.

Fixes: 2528
@ansible-zuul
Copy link
Contributor

ansible-zuul bot commented Feb 15, 2020

Build succeeded.

@ssbarnea ssbarnea marked this pull request as ready for review February 15, 2020 16:21
@ssbarnea ssbarnea self-assigned this Feb 15, 2020
@ansible-zuul
Copy link
Contributor

ansible-zuul bot commented Feb 15, 2020

Build succeeded (gate pipeline).

@ansible-zuul ansible-zuul bot merged commit 0b9794b into ansible:master Feb 15, 2020
@ssbarnea ssbarnea deleted the fix/2528-pco branch July 19, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmsimard dmsimard Awaiting requested review from dmsimard

@LukeShortCloud LukeShortCloud Awaiting requested review from LukeShortCloud

@sshnaidm sshnaidm Awaiting requested review from sshnaidm

Assignees

@ssbarnea ssbarnea

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

testinfra template breaks pytest collection
1 participant
@ssbarnea