Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support root containers for podman #2716

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Conversation

sshnaidm
Copy link
Contributor

@sshnaidm sshnaidm commented Jun 7, 2020

By adding "rootless: false" support root containers for podman
driver.

PR Type

  • Feature Pull Request

Fixes #2713

@ssbarnea
Copy link
Member

recheck

@ssbarnea ssbarnea self-requested a review June 17, 2020 16:25
@@ -355,6 +355,7 @@ def pre_validate_base_schema(env, keep_string):
"network": {"type": "string"},
"cert_path": {"type": "string"},
"tls_verify": {"type": "boolean"},
'rootless': {'type': 'boolean'},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet this will be refused by black and converted to double quotes.

Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix quotes :D

By adding "rootless: false" support root containers for podman
driver.
@ansible-zuul ansible-zuul bot removed the gate label Jun 17, 2020
@sshnaidm sshnaidm requested a review from ssbarnea June 17, 2020 21:59
@ssbarnea ssbarnea merged commit f7050c0 into ansible:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a config option to run podman as root
2 participants