Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove constraints requirement files #3981

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

zhan9san
Copy link
Contributor

Could you kindly explain which value does these files(requirements.txt and requirements-lock.txt) bring?

Without constraints

If someone report an issue related to a specific version of dependency and if this issue is fixed in a higher version, we can update the lower bound of the dependency in .config/requirements.in.


Molecule's dependencies are defined in .config/requirements.in. IMHO, it is enough.

A set of command line tools to help you keep your pip-based packages fresh, even when you've pinned them. You do pin them, right? (In building your Python application and its dependencies for production, you want to make sure that your builds are predictable and deterministic.)

Capping dependencies has long term negative effects, especially for libraries, and should never be taken lightly. A library is not installed in isolation; it has to live with other libraries in a shared environment. Only add a cap if a dependency is known to be incompatible or there is a high (>75%) chance of it being incompatible in its next release.

Reference

https://iscinumpy.dev/post/bound-version-constraints/#tldr
https://pypi.org/project/pip-tools/

@audgirka
Copy link
Contributor

@zhan9san As there can be clashes between the compatible versions of dependencies, we need the lock file to restrict or lock a dependency version.

@audgirka
Copy link
Contributor

@cidrblock any thoughts on this?

@cidrblock
Copy link
Contributor

It seems to reduce the complexity quite a bit, which I do like. I say let's give it a go, if we have reoccuring version problems we can always reintroduce tighter locking in the future.

@audgirka audgirka merged commit fa12794 into ansible:main Jul 31, 2023
13 checks passed
@zhan9san zhan9san deleted the feautre/remove-constraints branch July 31, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants