Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid requests 2.32.0 during testing #4185

Merged
merged 1 commit into from
May 20, 2024
Merged

Avoid requests 2.32.0 during testing #4185

merged 1 commit into from
May 20, 2024

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented May 20, 2024

Apparently requests==2.32.0 is incompatible with vendored versions of docker-py from inside community.docker collection. We do not have a direct dependency on that but one of our integration tests fails, so we only update our test dependencies.

Related: docker/docker-py#3256
Related: ansible-collections/community.docker#860
Related: ansible-collections/community.docker#861

@ssbarnea ssbarnea requested a review from a team as a code owner May 20, 2024 18:57
@github-actions github-actions bot added the bug label May 20, 2024
@ssbarnea ssbarnea changed the title Avoid requests 2.32.0 during testings Avoid requests 2.32.0 during testing May 20, 2024
@ssbarnea ssbarnea requested a review from Qalthos May 20, 2024 18:58
@ssbarnea ssbarnea requested a review from cidrblock May 20, 2024 18:59
@ssbarnea ssbarnea merged commit 9bfd052 into main May 20, 2024
8 of 13 checks passed
@ssbarnea ssbarnea deleted the fix/requests-2.32.0 branch May 20, 2024 19:04
aminvakil added a commit to aminvakil/ansible-role-node-exporter that referenced this pull request May 22, 2024
aminvakil added a commit to aminvakil/lamp that referenced this pull request May 22, 2024
aminvakil added a commit to aminvakil/ansible-role-docker-installation that referenced this pull request May 22, 2024
@abhinabphy
Copy link

how to revert the requests back to 2.31.0 here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants