Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightspeed: rely on electron's fetch #1498

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

lightspeed: rely on electron's fetch #1498

wants to merge 2 commits into from

Conversation

goneri
Copy link
Contributor

@goneri goneri commented Aug 5, 2024

  • fetch() in the main process works well with the proxy
  • this is not the case from within the LSP server

TODO:

  • Move away from the LSP server
  • Error handling

@goneri goneri requested review from a team as code owners August 5, 2024 22:26
@goneri goneri marked this pull request as draft August 5, 2024 22:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found:

goneri and others added 2 commits August 5, 2024 18:27
@goneri
lightspeed: rely on electron's fetch
d28846c 
- `fetch()` in the main process works well with the proxy
- this is not the case from within the LSP server

TODO:

- Move away from the LSP server
- Error handling
@pre-commit-ci
chore: auto fixes from pre-commit.com hooks
7557db9 
for more information, see https://pre-commit.ci
@TamiTakamiya
Copy link
Collaborator

I also verified that the loadFetch() worked well on the extension side (in base.ts), but the loadFetch() on LSP (in ansibleLanguageService.ts) failed. require("electron") throws an error (Cannot find module 'electron')

@goneri
Copy link
Contributor Author

goneri commented Aug 7, 2024

I also verified that the loadFetch() worked well on the extension side (in base.ts), but the loadFetch() on LSP (in ansibleLanguageService.ts) failed. require("electron") throws an error (Cannot find module 'electron')

Yes, I also faced the issue. This is the main reason why I decided to move away from LSP. It was going to make our life miserable with the HTTP proxy when NTLM/Kerberos is in the picture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
🧰 devtools project board
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goneri @TamiTakamiya