Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable eslint strict type checks #1561

Merged
merged 16 commits into from
Oct 9, 2024
Merged

Enable eslint strict type checks #1561

merged 16 commits into from
Oct 9, 2024

Conversation

tanwigeetika1618
Copy link
Contributor

@tanwigeetika1618 tanwigeetika1618 commented Oct 3, 2024 •
edited
Loading

Related #1225

Enable Strict Type Checking with tseslint.configs.strictTypeChecked

Description

  • Integrated tseslint.configs.strictTypeChecked to enforce strict type checking across the project.
  • Made necessary adjustments to files to comply with the strict type-checking rules.

Changes Made

  • Enabled strict type checking by adding tseslint.configs.strictTypeChecked in the ESLint configuration.
  • Refactored various files to resolve type-related issues flagged by the new configuration.
  • Updated type annotations and resolved any type mismatches to ensure the code passes the stricter checks.

@github-actions github-actions bot added the bug Something isn't working label Oct 3, 2024
@tanwigeetika1618 tanwigeetika1618 marked this pull request as ready for review October 6, 2024 17:32
@tanwigeetika1618 tanwigeetika1618 requested review from a team as code owners October 6, 2024 17:32
@audgirka audgirka mentioned this pull request Oct 9, 2024
Merged
@audgirka
Copy link
Contributor

audgirka commented Oct 9, 2024 •
edited
Loading

@ssbarnea @alisonlhart This PR is ready to be merged

@ssbarnea ssbarnea changed the title chore : Apply strict type checked Enable eslint strict type checks Oct 9, 2024
@ssbarnea ssbarnea merged commit c1671de into ansible:main Oct 9, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TamiTakamiya TamiTakamiya TamiTakamiya left review comments

@ssbarnea ssbarnea ssbarnea approved these changes

@audgirka audgirka audgirka approved these changes

@alisonlhart alisonlhart alisonlhart approved these changes

@sshedmake sshedmake Awaiting requested review from sshedmake sshedmake is a code owner automatically assigned from ansible/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug Something isn't working
Projects
🧰 devtools project board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tanwigeetika1618 @audgirka @ssbarnea @TamiTakamiya @alisonlhart