Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable validate-build option to build-library action #473

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

RobPasMue
Copy link
Member

As title says. Coming from an internal request by @anscfrisson. Some libraries may have long descriptions that are causing the twine check to validate. These libraries will never be published to PyPI in this state (since PyPI upload will probably fail). However it will allow them to continue to build the library using our actions.

@RobPasMue RobPasMue self-assigned this Apr 25, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner April 25, 2024 07:34
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement General improvements to existing features label Apr 25, 2024
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobPasMue RobPasMue merged commit 7d34a0e into main Apr 25, 2024
16 checks passed
@RobPasMue RobPasMue deleted the feat/validate-build-optional branch April 25, 2024 13:03
@anscfrisson
Copy link
Contributor

Thank you @RobPasMue !

@RobPasMue
Copy link
Member Author

Give it a try and let us know =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants