Merge pull request #56 from pyansys/fix/remove-todos

Remove obsolete TODOs.

src/ansys/grantami/bomanalytics/__init__.py

@@ -2,4 +2,3 @@
 from ._exceptions import GrantaMIException
 
 __version__ = "0.1.0dev"
-# TODO use STK to extend BoM services objects? e.g. adding all references to sparsely referenced object

src/ansys/grantami/bomanalytics/_item_results.py

@@ -472,7 +472,7 @@ def substances(self) -> List[ImpactedSubstance]:
 
         results = []
         for legislation_result in self.substances_by_legislation.values():
-            results.extend(legislation_result)  # TODO: Merge these property, i.e. take max amount? range?
+            results.extend(legislation_result)
         return results
 
     def __repr__(self) -> str:

src/ansys/grantami/bomanalytics/_query_results.py

@@ -184,7 +184,7 @@ def impacted_substances_by_legislation(self) -> Dict[str, List["ImpactedSubstanc
             ) in item_result.substances_by_legislation.items():
                 results[legislation_name].extend(
                     legislation_result
-                )  # TODO: Merge these property, i.e. take max amount? range?
+                )
         return dict(results)
 
     @property
@@ -208,7 +208,7 @@ def impacted_substances(self) -> List["ImpactedSubstance"]:
         results = []
         for item_result in self._results:
             for legislation_result in item_result.substances_by_legislation.values():
-                results.extend(legislation_result)  # TODO: Merge these property, i.e. take max amount? range?
+                results.extend(legislation_result)
         return results
 
 

src/ansys/grantami/bomanalytics/indicators.py

@@ -358,7 +358,7 @@ def __le__(self, other: object) -> bool:
         return self == other or self < other
 
 
-class RoHSIndicator(_Indicator):  # TODO Think about the class hierarchy here, IndicatorDefinition vs Result
+class RoHSIndicator(_Indicator):
     """Indicator object that represents RoHS-type compliance of a BoM object against one or more
     legislations.
 

src/ansys/grantami/bomanalytics/queries.py

@@ -478,7 +478,7 @@ def with_stk_records(self: Query_Builder, stk_records: List[Dict[str, str]]) ->
         <MaterialCompliance: 2 materials, batch size = 100, 0 indicators>
         """
 
-        record_guids: List[str] = [r["record_guid"] for r in stk_records]  # TODO Handle database key
+        record_guids: List[str] = [r["record_guid"] for r in stk_records]
         query_builder: Query_Builder = self.with_record_guids(record_guids)
         return query_builder