Fixup workflow trigger and skips #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andy-Grigg
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
These changes are as discussed. We'll now always run documentation tests for dependabot PRs even if the unit tests or style checks fail. This is fine, because these types of checks are very quick to run, and will give us a better picture of what the failures were.
Integration test execution is unaffected, as demonstrated by the checks on this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable github.ref_name points to the pull request branch, not the source, so the previous change did not skip correctly. This uses the event information to get the source of the PR which does work.
Also simplify the logic around documentation building.