Fix GitHub release #276
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,8 +52,8 @@ jobs: | |
| doc-artifact-name: Documentation-html | ||
|
|
||
| Release: | ||
| # if: contains(github.ref, 'refs/tags') && github.event_name == 'push' | ||
| needs: integration_checks | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
|
|
@@ -71,28 +71,43 @@ jobs: | |
| - uses: actions/download-artifact@v3 | ||
| with: | ||
| name: Documentation-pdf | ||
| path: ~/dist | ||
|
|
||
| - uses: actions/download-artifact@v3 | ||
| with: | ||
| name: Documentation-html | ||
| path: ~/dist | ||
|
|
||
| - name: "Compressing HTML documentation" | ||
| uses: vimtor/[email protected] | ||
| with: | ||
| files: ~/dist/Documentation-html | ||
| dest: ~/dist/documentation-html.zip | ||
|
|
||
| # - name: "Deploy stable documentation" | ||
| # uses: pyansys/actions/doc-deploy-stable@v4 | ||
| # with: | ||
| # cname: ${{ env.DOCUMENTATION_CNAME }} | ||
| # token: ${{ secrets.GITHUB_TOKEN }} | ||
| # doc-artifact-name: Documentation-html | ||
|
|
||
| # # note how we use the PyPI tokens | ||
| # - name: Upload to PyPI | ||
| # run: | | ||
| # pip install twine | ||
| # twine upload --non-interactive --skip-existing ~/**/*.whl | ||
| # env: | ||
| # TWINE_USERNAME: __token__ | ||
| # TWINE_PASSWORD: ${{ secrets.PYPI_TOKEN }} | ||
|
|
||
| - name: Release | ||
| uses: softprops/action-gh-release@v1 | ||
| with: | ||
| prerelease: true | ||
|
There was a problem hiding this comment. Presumably these three additions will be removed before merge. |
||
| tag_name: v1.1.3b0 | ||
| draft: true | ||
| generate_release_notes: true | ||
| files: | | ||
| ~/dist/*.whl | ||
| ~/dist/documentation-html.zip | ||
| ~/dist/*.pdf | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't need to explicitely zip artifacts, if you mark a folder for upload then it should be zipped by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't downloading it unzip it then?
Edit: I think I misunderstood you. Do you mean the artifact should be zipped already or when using the release action pointing it at a folder should zip it?