Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation, update vale #483

Merged
merged 10 commits into from
Apr 19, 2024
Merged

Conversation

Andy-Grigg
Copy link
Collaborator

@Andy-Grigg Andy-Grigg commented Apr 16, 2024

Closes #389
Closes #256

Restructure the documentation to be more like grantami-jobqueue, which involves re-using some elements of the README in the getting started section.

Also update the vale config to use the new version.

@PipKat I haven't changed a whole lot here, but it's been a while since this documentation was written. Also, I believe the last major release was reviewed by the MatBU docs team, but not by you.

This PR paves the way for us to make the API documentation terser in the future if we should decide do, by moving the prose to the User Guide section.

@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Related with project dependencies maintenance Package and maintenance related labels Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.32%. Comparing base (54016da) to head (01216ce).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #483   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files          18       18           
  Lines        2434     2434           
=======================================
  Hits         2369     2369           
  Misses         65       65           
Flag Coverage Δ
integration 82.49% <100.00%> (ø)
unittests 96.87% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ludovicsteinbach ludovicsteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andy-Grigg I found places where we weren't following the Google style guidelines, especially in the examples. Sorry that my commit ended up with changes to so many files. As always, reach out with any questions.

@Andy-Grigg
Copy link
Collaborator Author

@Andy-Grigg I found places where we weren't following the Google style guidelines, especially in the examples. Sorry that my commit ended up with changes to so many files. As always, reach out with any questions.

It's all good, thank you for the review!

@Andy-Grigg Andy-Grigg added this pull request to the merge queue Apr 19, 2024
Merged via the queue into main with commit 1b7ad7e Apr 19, 2024
28 checks passed
@Andy-Grigg Andy-Grigg deleted the doc/update-documentation-structure branch April 19, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related with project dependencies documentation Improvements or additions to documentation maintenance Package and maintenance related
Projects
None yet
3 participants