-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation, update vale #483
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
=======================================
Coverage 97.32% 97.32%
=======================================
Files 18 18
Lines 2434 2434
=======================================
Hits 2369 2369
Misses 65 65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Andy-Grigg I found places where we weren't following the Google style guidelines, especially in the examples. Sorry that my commit ended up with changes to so many files. As always, reach out with any questions.
It's all good, thank you for the review! |
Closes #389
Closes #256
Restructure the documentation to be more like grantami-jobqueue, which involves re-using some elements of the README in the getting started section.
Also update the vale config to use the new version.
@PipKat I haven't changed a whole lot here, but it's been a while since this documentation was written. Also, I believe the last major release was reviewed by the MatBU docs team, but not by you.
This PR paves the way for us to make the API documentation terser in the future if we should decide do, by moving the prose to the User Guide section.