Server response log examples #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e background on fluent interfaces. Requires an alternative way of "faking" the connection with monkey patching.
da1910
approved these changes
Jan 11, 2022
da1910
reviewed
Jan 11, 2022
| @@ -121,7 +121,9 @@ def messages(self) -> List[LogMessage]: | |||
| """[TECHDOCS] Messages generated by Granta MI when running the query. The presence of one or more messages means | |||
| something unexpected happened when running the query, but the query could still be completed. | |||
|
|
|||
| Messages are sorted in order of decreasing severity. | |||
| Messages are sorted in order of decreasing severity. Messages are also logged in the Service Layer log on the | |||
There was a problem hiding this comment.
Have we documented which logger the messages are logged to?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after #51. I have created the diff with the #51 branch as a base for easier reviewing.
Uses monkey patching of the Connection and Client classes to ensure we can inject server URL and credentials when running examples. This replaces the previous method of using a hidden cell, which would have been visible in download .py and .ipynb files.
The monkey patching is done in the ipython profile, which means it's available for all notebooks. This approach requires running the examples tests in ipython as well, otherwise the required monkey patching doesn't happen.
I'm not convinced this is better than having the deleted cell, it's ultimately a tradeoff between: