Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to poetry as the build backend #55

Merged
merged 13 commits into from
Jan 18, 2022
Merged

Move to poetry as the build backend #55

merged 13 commits into from
Jan 18, 2022

Conversation

Andy-Grigg
Copy link
Collaborator

@Andy-Grigg Andy-Grigg commented Jan 14, 2022 •
edited
Loading

Closes #59
Closes #60

Switch to using poetry as the build backend. Some other related changes:

  • Pin versions for docs build dependencies
  • Simplify the CI/CD build step (dependencies are not needed to build the wheel)
  • Create an 'examples' extra, to make it easy for people to run examples
  • Delete setup.cfg and move remaining configs to their own files

da1910
da1910 approved these changes Jan 15, 2022
View reviewed changes
Copy link
Collaborator

@da1910 da1910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good improvement, a suggestion and a question, but feel free to merge

.github/workflows/ci_cd.yml Outdated Show resolved Hide resolved
.flake8 Show resolved Hide resolved
@Andy-Grigg
Copy link
Collaborator Author

@da1910 I'll hold off on merging this until you've completed your experiments with poetry.

@Andy-Grigg Andy-Grigg marked this pull request as draft January 17, 2022 12:57
@Andy-Grigg Andy-Grigg changed the title Move to flit as the build backend Move to poetry as the build backend Jan 18, 2022
@Andy-Grigg
Copy link
Collaborator Author

I have updated this PR to use poetry as the build backend.

Currently poetry install doesn't work because --find-links is not available, but I have confirmed that pip installing the wheel does work. Once the two dependencies are on pypi we'll be able to test this and update the documentation accordingly.

@Andy-Grigg Andy-Grigg marked this pull request as ready for review January 18, 2022 15:49
@Andy-Grigg Andy-Grigg mentioned this pull request Jan 18, 2022
Closed
@da1910
Copy link
Collaborator

da1910 commented Jan 18, 2022 •
edited
Loading

Changes look as I would expect, lack of find-links should be ok in the short term. 👍

@Andy-Grigg Andy-Grigg merged commit c550ef1 into main Jan 18, 2022
@Andy-Grigg Andy-Grigg deleted the maint/switch-build-backend branch January 18, 2022 16:53
Andy-Grigg pushed a commit that referenced this pull request Jan 11, 2024
@ludovicsteinbach
Merge pull request #55 from ansys/docs/sustainability-example
1aae470 
Docs: add sustainability example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da1910 da1910 da1910 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise minimum supported python version to 3.7 Switch to poetry as a build backend
2 participants
@Andy-Grigg @da1910