generated from ansys/template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start/stop integration test server on-demand #65
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andy-Grigg
changed the title
Check the server is healthy before testing
Start/stop integration test server on-demand
Jan 18, 2022
da1910
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about logging, otherwise looks good and seems to work just fine!
Andy-Grigg
pushed a commit
that referenced
this pull request
Jan 11, 2024
Rename external_id on part to external_identity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48
This PR enables the following functionality:
Don't stop the server if it wasn't started by this workflowThe final task isn't possible because the principal doesn't currently have permissions to inspect the status of the VM.
However, I have put the foundations in place to enable this by checking if the conclusion of the
start_vm
job was anything other thanskipped
. The idea being that in future we can add a job that checks the status (e.g.get_vm_status
), and then have thestart_vm
job proceed only if the result of theget_vm_status
job is something like 'stopped' or 'deallocated'.