Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix labelling workflow #581

Merged
merged 4 commits into from
May 6, 2024
Merged

Fix labelling workflow #581

merged 4 commits into from
May 6, 2024

Conversation

Andy-Grigg
Copy link
Contributor

@Andy-Grigg Andy-Grigg commented May 3, 2024

Closes #582

The labelling workflow currently runs on pushes to main. This should only happen if the labels.yml file (which is also missing) is updated.

This PR makes the following changes:

  • Add the label definition, copied from grantami-recordlists
  • Only trigger on pushes to main if the label definition is modified
  • Only run the labeler step for pull requests (i.e. not for pushes)

Assuming this works as expected, we should copy these changes to the other repos

@github-actions github-actions bot added the maintenance Package and maintenance related label May 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.25%. Comparing base (8bd1398) to head (24b846d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #581   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files           7        7           
  Lines         783      783           
=======================================
  Hits          738      738           
  Misses         45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ludovicsteinbach
Copy link
Contributor

I had voluntarily removed the label syncer and label config file, but should have removed the push trigger entirely instead of just removing the path filter.
I don't really see the point of declaring labels in a config file and preventing use of any other labels.

@Andy-Grigg
Copy link
Contributor Author

I had voluntarily removed the label syncer and label config file, but should have removed the push trigger entirely instead of just removing the path filter. I don't really see the point of declaring labels in a config file and preventing use of any other labels.

I suppose the intention is that we have a constant defined set of labels with consistent colors across repositories. I don't know, it seems sensible to me.

@Andy-Grigg Andy-Grigg added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 5a63f3f May 6, 2024
38 checks passed
@Andy-Grigg Andy-Grigg deleted the ci/add-label-filter branch May 6, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix labeler CI workflow
4 participants