Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply hook changes after add-license-headers runs #108

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Apply hook changes after add-license-headers runs #108

merged 3 commits into from
Jan 4, 2024

Conversation

klmcadams
Copy link
Contributor

  • Save file before add-license-headers is run
  • Compare the file before add-license-headers is run to the file after add-license-headers is run
  • If there are differences, apply the changes from before add-license-headers was run to the file

@klmcadams klmcadams changed the title Apply hook changes after the add-license-headers runs Apply hook changes after add-license-headers runs Jan 3, 2024
@github-actions github-actions bot added the enhancement New features or code improvements label Jan 3, 2024
RobPasMue
RobPasMue approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM!

src/ansys/pre_commit_hooks/add_license_headers.py Show resolved Hide resolved
@klmcadams klmcadams merged commit 8665189 into main Jan 4, 2024
30 checks passed
@klmcadams klmcadams deleted the feat/hook-conflicts branch January 4, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees
No one assigned
Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klmcadams @RobPasMue