Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom argument for the copyright's start year & update add_hook_changes #111

Merged
merged 11 commits into from
Jan 9, 2024

Conversation

klmcadams
Copy link
Contributor

Added a custom argument for the copyright line's start year. Allows users to specify if they want their start year to be something other than the current year.

Added file reading exception catching (try/except) to pass whenever there are issues reading unfamiliar characters. For example, these types of characters:

ÞĀĂĄĆĈĊČĎĐĒĔĖĘĚĜĞĠĢĤĦĨĪĬĮİIJĴ

Closes #110

@github-actions github-actions bot added the maintenance Package and maintenance related label Jan 8, 2024
@klmcadams klmcadams changed the title Added custom argument for the copyright's start year & file reading exception catching Added custom argument for the copyright's start year & update add_hook_changes Jan 8, 2024
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. LGTM

src/ansys/pre_commit_hooks/add_license_headers.py Outdated Show resolved Hide resolved
@klmcadams klmcadams merged commit 6fe5379 into main Jan 9, 2024
30 checks passed
@klmcadams klmcadams deleted the maint/startyear_errorcatch branch January 9, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add start year for copyright
2 participants