Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: bump reuse to v3.0.2 in add-license-headers #163

Merged
merged 9 commits into from
Apr 16, 2024
Merged

Conversation

klmcadams
Copy link
Contributor

  • Changed headers.run() to _annotate.run()
  • Removed recursion from check_exists()
  • Removed lint_json["non_compliant"]["missing_licenses"] check:
    • This just checks that the license file is located in the LICENSES folder. I think it makes more sense just to check lint_json["non_compliant"]["missing_copyright_info"] and lint_json["non_compliant"]["missing_licensing_info"]. In test_multiple_files, the header was added to the first file, but lint_json["non_compliant"]["missing_licenses"] had the first file as a value even though LICENSES/MIT.txt existed in the repository at that moment. Whenever we added two more files & ran the hook with all three files, then a second SPDX line was added to the first file, which isn't correct.

@github-actions github-actions bot added the maintenance Package and maintenance related label Apr 16, 2024
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some minor comments only

.pre-commit-config.yaml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@klmcadams klmcadams merged commit fad76f5 into main Apr 16, 2024
34 checks passed
@klmcadams klmcadams deleted the maint/reuse-v3 branch April 16, 2024 15:38
@RobPasMue RobPasMue linked an issue Apr 16, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix reuse 3.x.x breaking changes
3 participants