Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semantic versioning check in tech-review hook #194

Merged
merged 25 commits into from
Jul 15, 2024
Merged

Conversation

klmcadams
Copy link
Contributor

Fix semver check for strings that contain "dev," like "11.0.dev1"

The semver PyPI package marks this version format as invalid

@klmcadams klmcadams requested a review from RobPasMue July 1, 2024 14:58
@github-actions github-actions bot added the bug Something isn't working label Jul 1, 2024
@github-actions github-actions bot added the maintenance Package and maintenance related label Jul 10, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 12, 2024
@klmcadams klmcadams merged commit cdaef96 into main Jul 15, 2024
34 checks passed
@klmcadams klmcadams deleted the fix/semver-check branch July 15, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants