Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update code base to fix bandit warnings #209

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Conversation

SMoraisAnsys
Copy link
Contributor

As title says.

@SMoraisAnsys SMoraisAnsys marked this pull request as draft July 29, 2024 12:29
@SMoraisAnsys SMoraisAnsys marked this pull request as ready for review July 29, 2024 12:32
@SMoraisAnsys
Copy link
Contributor Author

@klmcadams I saw this while working on pyaedt (I had some leftover after the tests overall the license checker haha)
I should start to work on #199 this week

@klmcadams
Copy link
Contributor

@SMoraisAnsys Could you make a test case to show that it suppresses bandit warnings?

@SMoraisAnsys
Copy link
Contributor Author

@SMoraisAnsys Could you make a test case to show that it suppresses bandit warnings?

I'm not sure to understand what you mean by that. Like creating an empty repo with the modified file and a dedicated workflow to see the changes ?
Bellow are screenshots from bandit ouput (the first is the result from main branch, the second is the result from this PR)
image
image

@klmcadams
Copy link
Contributor

Now I'm confused. I will message you

@klmcadams klmcadams merged commit 813c0bf into main Jul 31, 2024
34 checks passed
@klmcadams klmcadams deleted the chore/bandit-update branch July 31, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants