feat: leverage reuse vcs Git strategy #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobPasMue
reviewed
Aug 7, 2024
RobPasMue
approved these changes
Aug 7, 2024
|
@klmcadams feel free to review and merge when you want. We should do a release right after and close #215 and #214 |
klmcadams
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #216 which was opened from a fork...
Seems like a big overhead when using
add-license-headeris related to the fact that we also handle (uselessly) files and directory ignored by version control. This PR addsVCSStrategyGitwhich should handle Git related ignores when checking a repo.I did a test with this branch on pyaedt and the restitution time difference is huge.
Using
took seconds when a file was modified while the using the current pre-commit-hooks takes minute(s)
If this PR gets merged we should close #215
Closes #214