Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create custom flags for add-license-header #44

Merged
merged 9 commits into from
Sep 8, 2023
Merged

Conversation

klmcadams
Copy link
Contributor

Created custom flags for loc (allow 1+ locations to be listed), license (license other than MIT), copyright (unique copyright line other than Ansys), and template (allow different template name, name.jinja2). Also created test to test the custom flag implementation. Updated README as well. This closes #41 and #42.

@klmcadams klmcadams changed the title Create custom flags Create custom flags for add-license-header Sep 7, 2023
@github-actions github-actions bot added the enhancement New features or code improvements label Sep 7, 2023
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job here. On following PRs, let's try to improve the assertions we do on the tests by checking the output files and similar. For now, it's solid. Merging and releasing

@RobPasMue RobPasMue merged commit a44248c into main Sep 8, 2023
26 checks passed
@RobPasMue RobPasMue deleted the feat/custom-flags branch September 8, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add command line args for template name, copyright line, and license
2 participants