Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed loc argument & passed in committed files #57

Merged
merged 9 commits into from
Sep 14, 2023
Merged

Removed loc argument & passed in committed files #57

merged 9 commits into from
Sep 14, 2023

Conversation

klmcadams
Copy link
Contributor

  • Removed loc argument from the hook

  • Allowed committed files to be passed into the hook

  • Updated README

    • Removed loc argument info
    • Added how to exclude specific files, as well as specific file types either in the .reuse/dep5 or .pre-commit-config.yaml

Closes #46 and #56

@github-actions github-actions bot added the bug Something isn't working label Sep 13, 2023
RobPasMue
RobPasMue approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job @klmcadams

src/ansys/pre_commit_hooks/add_license_headers.py Show resolved Hide resolved
@RobPasMue
Copy link
Member

This one will cause breaking changes (since the args have been modified). A minor bump will be required. We should try to work on the other issues before we do the release in that case.

@RobPasMue RobPasMue linked an issue Sep 14, 2023 that may be closed by this pull request
.reuse/dep5 is ignored if running in a location other than ./ #56
Closed
2 tasks
@klmcadams klmcadams merged commit 17991e5 into main Sep 14, 2023
26 checks passed
@klmcadams klmcadams deleted the fix/ignore-files branch September 14, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@klmcadams @RobPasMue