Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update headers & improve unit tests #69

Merged
merged 7 commits into from
Oct 6, 2023
Merged

Update headers & improve unit tests #69

merged 7 commits into from
Oct 6, 2023

Conversation

klmcadams
Copy link
Contributor

  • Improve unit tests
    • Check headers are in files
  • Update headers if headers already exist in the files

Closes #47 and #48

@klmcadams klmcadams changed the title Feat/check headers Update headers & improve unit tests Oct 4, 2023
@github-actions github-actions bot added the enhancement New features or code improvements label Oct 4, 2023
@klmcadams klmcadams linked an issue Oct 4, 2023 that may be closed by this pull request
Improve assertions on testing #48
Closed
RobPasMue
RobPasMue approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. Apart from that, all good.

src/ansys/pre_commit_hooks/add_license_headers.py Outdated Show resolved Hide resolved
src/ansys/pre_commit_hooks/add_license_headers.py Outdated Show resolved Hide resolved
src/ansys/pre_commit_hooks/add_license_headers.py Outdated Show resolved Hide resolved
klmcadams and others added 3 commits October 6, 2023 09:19
@klmcadams @RobPasMue
call get_full_paths(args.files)
d0bdc12 
Co-authored-by: Roberto Pastor Muela <[email protected]>
@klmcadams @RobPasMue
avoid mutating list in function
2ab8935 
Co-authored-by: Roberto Pastor Muela <[email protected]>
@klmcadams @RobPasMue
remove mutating list line
56aeeb0 
Co-authored-by: Roberto Pastor Muela <[email protected]>
@klmcadams klmcadams merged commit dd2b4f9 into main Oct 6, 2023
27 checks passed
@klmcadams klmcadams deleted the feat/check-headers branch October 6, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees
No one assigned
Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve assertions on testing Licenses should be checked despite they already exist
2 participants
@klmcadams @RobPasMue