Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix add-license-headers to keep edits from previously run hooks #88

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Fix add-license-headers to keep edits from previously run hooks #88

merged 5 commits into from
Nov 13, 2023

Conversation

klmcadams
Copy link
Contributor

Closes #82

@github-actions github-actions bot added the bug Something isn't working label Nov 10, 2023
RobPasMue
RobPasMue approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good but I think we might need to talk about the logic implemented in add_hook_changes

src/ansys/pre_commit_hooks/add_license_headers.py Show resolved Hide resolved
src/ansys/pre_commit_hooks/add_license_headers.py Show resolved Hide resolved
@RobPasMue
Copy link
Member

Feel free to merge @klmcadams

@klmcadams klmcadams enabled auto-merge (squash) November 13, 2023 16:55
@klmcadams klmcadams merged commit bf20bd4 into main Nov 13, 2023
25 checks passed
@klmcadams klmcadams deleted the fix/keep-hook-updates branch November 13, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add-license-headers undoes earlier pre-commit hook changes sometimes
2 participants
@klmcadams @RobPasMue