Skip to content

Commit

Permalink
Fillet chamfer docstring update (#3768)
Browse files Browse the repository at this point in the history
* fillet and chamfer docstring correction

* Add UT

---------

Co-authored-by: Samuel Lopez <[email protected]>
Co-authored-by: Samuel Lopez <[email protected]>
  • Loading branch information
3 people authored Oct 19, 2023
1 parent fe8f831 commit da83359
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 2 additions & 0 deletions _unittest/test_08_Primitives3D.py
Original file line number Diff line number Diff line change
Expand Up @@ -681,6 +681,8 @@ def test_43_fillet_and_undo(self):
assert o.edges[0].fillet()
self.aedtapp._odesign.Undo()
assert o.edges[0].fillet()
r = self.create_rectangle(name="MyRect")
assert not r.edges[0].fillet()

def test_44_create_polyline_basic_segments(self):
prim3D = self.aedtapp.modeler
Expand Down
6 changes: 3 additions & 3 deletions pyaedt/modeler/cad/elements3d.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class EdgeTypePrimitive(object):

@pyaedt_function_handler()
def fillet(self, radius=0.1, setback=0.0):
"""Add a fillet to the selected edge.
"""Add a fillet to the selected edges in 3D/vertices in 2D.
Parameters
----------
Expand Down Expand Up @@ -98,7 +98,7 @@ def fillet(self, radius=0.1, setback=0.0):
if self._object3d.is3d:
edge_id_list = [self.id]
else:
self._object3d.logger.error("Filet is possible only on a vertex in 2D designs.")
self._object3d.logger.error("Fillet is possible only on a vertex in 2D designs.")
return False

vArg1 = ["NAME:Selections", "Selections:=", self._object3d.name, "NewPartsModelFlag:=", "Model"]
Expand All @@ -116,7 +116,7 @@ def fillet(self, radius=0.1, setback=0.0):

@pyaedt_function_handler()
def chamfer(self, left_distance=1, right_distance=None, angle=45, chamfer_type=0):
"""Add a chamfer to the selected edge.
"""Add a chamfer to the selected edges in 3D/vertices in 2D.
Parameters
----------
Expand Down

0 comments on commit da83359

Please sign in to comment.