Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new methods to identify terminal nets connections plus excitations refactoring #1984

Merged
merged 30 commits into from
Nov 17, 2022

Conversation

maxcapodi78
Copy link
Collaborator

in particular method
are_port_reference_terminals_connected is doing the following:

  • get all ports
  • get references object
  • get reference net
  • for each reference object is getting connected objects
  • checks for intersections of those list to see if there is a common return path between ports.

Excitations refactoring includes the following:

  • multiple classes for Excitations, Probes and Sources
  • A lot of new properties in excitations
  • properties are part of Edb class now and shared with core_siwave and core_hfss classes

in particular method
are_port_reference_terminals_connected is doing the following:
- get all ports
- get references object
- get reference net
- for each reference object is getting connected objects
- checks for intersections of those list to see if there is a common return path between ports.
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #1984 (cefd92b) into main (525b843) will increase coverage by 0.02%.
The diff coverage is 79.50%.

@@            Coverage Diff             @@
##             main    #1984      +/-   ##
==========================================
+ Coverage   80.20%   80.23%   +0.02%     
==========================================
  Files         108      108              
  Lines       46252    46686     +434     
==========================================
+ Hits        37098    37457     +359     
- Misses       9154     9229      +75     

pyaedt/edb_core/nets.py Outdated Show resolved Hide resolved
pyaedt/edb_core/nets.py Outdated Show resolved Hide resolved
pyaedt/edb.py Outdated Show resolved Hide resolved
pyaedt/edb.py Outdated Show resolved Hide resolved
pyaedt/__init__.py Outdated Show resolved Hide resolved
pyaedt/edb_core/nets.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maxcapodi78 maxcapodi78 merged commit 57f3ca6 into main Nov 17, 2022
@maxcapodi78 maxcapodi78 deleted the edb_excitation_refactor branch November 17, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants