Replace all remaining os.name checks with is_windows, is_linux booleans Ref: #2689 #2690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxcapodi78
approved these changes
Mar 22, 2023
Codecov Report
@@ Coverage Diff @@
## main #2690 +/- ##
==========================================
- Coverage 80.63% 80.63% -0.01%
==========================================
Files 163 163
Lines 54020 54020
==========================================
- Hits 43561 43557 -4
- Misses 10459 10463 +4 |
kbhagat-ansys
added a commit
that referenced
this pull request
Mar 22, 2023
kbhagat-ansys
added a commit
that referenced
this pull request
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all remaining os.name checks with is_windows, is_linux booleans Ref: #2689
Request #2688
The PR #2670 introduced
is_windowsandis_linuxbooleans.We can replace all
os.name == "posix",os.name != "posix",os.name == "nt",os.name != "nt"with the booleans