improve Primitives3D

[tizianrot]

fixed docstrings for create_cylinder
fixed input list for create_box and create_polyhedron

[codecov]

Codecov Report

Merging #3525 (2659027) into main (dcc57a0) will increase coverage by 0.00%.
The diff coverage is 89.09%.

@@           Coverage Diff           @@
##             main    #3525   +/-   ##
=======================================
  Coverage   81.04%   81.05%           
=======================================
  Files         179      179           
  Lines       61870    61908   +38     
=======================================
+ Hits        50143    50177   +34     
- Misses      11727    11731    +4     

[Samuelopez-ansys]

@tizianrot @gmalinve Please could you review the suggested modifications and push them? First update the branch please

[gmalinve]

@tizianrot there are still some things to fix in the already commited changes.
I see that there's still something to fix in other methods such as create_cylinder, create_polyhedron (you are asserting only the center position but there's also the start position), create_cone, create_bondwire, create_rectangle etc.

[Samuelopez-ansys]

@tizianrot Please could you implement the suggestions and push again? Thanks

[PipKat]

Thanks so much for rewording these message strings so that they follow our style guidelines! Great work!

[gmalinve]

Hi @PipKat, thanks for reviewing!

I just pushed the latest commit in order to apply your advice to all messages in that class.
Could you please double check that everything is fine now?

Thanks!

Giulia

[PipKat]

@gmalinve I leave marking a PR as approved to someone with technical expertise. I only review the docstrings and prose--which looks fine. You'll need a technical team member to approve the PR.

[gmalinve]

@PipKat yes, I meant if you could review the doc since I changed other docstrings.
Thanks!

[Samuelopez-ansys]

Great work