Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement object CS #3557

Merged
merged 20 commits into from
Sep 20, 2023
Merged

implement object CS #3557

merged 20 commits into from
Sep 20, 2023

Conversation

gmalinve
Copy link
Contributor

No description provided.

@gmalinve gmalinve added the enhancement New features or code improvements label Sep 13, 2023
@gmalinve gmalinve self-assigned this Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023 •
edited
Loading

Codecov Report

Merging #3557 (a9c7a05) into main (66a10e6) will decrease coverage by 0.18%.
The diff coverage is 70.46%.

❗ Current head a9c7a05 differs from pull request most recent head 707e594. Consider uploading reports for the commit 707e594 to get more accurate results

@@            Coverage Diff             @@
##             main    #3557      +/-   ##
==========================================
- Coverage   81.05%   80.87%   -0.18%     
==========================================
  Files         178      178              
  Lines       60880    61216     +336     
==========================================
+ Hits        49344    49509     +165     
- Misses      11536    11707     +171

Alberto-DM
Alberto-DM requested changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@Alberto-DM Alberto-DM left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi gmalinve, we need to have a call about this PR :)

@gmalinve gmalinve marked this pull request as ready for review September 18, 2023 10:44
@gmalinve gmalinve linked an issue Sep 19, 2023 that may be closed by this pull request
Create ObjectCS #3266
Closed
Alberto-DM
Alberto-DM approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@Alberto-DM Alberto-DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job!

@gmalinve gmalinve enabled auto-merge (squash) September 20, 2023 08:08
@gmalinve gmalinve merged commit c364c40 into main Sep 20, 2023
10 checks passed
@gmalinve gmalinve deleted the object_CS branch September 20, 2023 08:14
MaxJPRey
MaxJPRey reviewed Sep 20, 2023
View reviewed changes
pyaedt/modeler/cad/Modeler.py
- list in which case it refers to the point coordinate system ``[x, y, z]`` that the x axis points to.
The value can be:

- An integer, in which case it refers to the entity IDd.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- An integer, in which case it refers to the entity IDd.
- An integer, in which case it refers to the entity ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxJPRey MaxJPRey MaxJPRey left review comments

@PipKat PipKat PipKat left review comments

@Alberto-DM Alberto-DM Alberto-DM approved these changes

@maxcapodi78 maxcapodi78 Awaiting requested review from maxcapodi78

@Samuelopez-ansys Samuelopez-ansys Awaiting requested review from Samuelopez-ansys

Assignees

@gmalinve gmalinve

Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create ObjectCS
4 participants
@gmalinve @PipKat @Alberto-DM @MaxJPRey