Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 3386 patch example update #3566

Merged
merged 87 commits into from
Sep 21, 2023
Merged

Commits on May 8, 2023

  1. Configuration menu
    Copy the full SHA
    06b63c7 View commit details
    Browse the repository at this point in the history
  2. Update names.

    Devin-Crawford committed May 8, 2023
    Configuration menu
    Copy the full SHA
    78e613a View commit details
    Browse the repository at this point in the history
  3. Replace assert in Primitives3D.py

    assert should not be used in productive code.
    Devin-Crawford committed May 8, 2023
    Configuration menu
    Copy the full SHA
    963b20e View commit details
    Browse the repository at this point in the history
  4. Refactor MaterialLib.Materials.duplicate_materials

    Allow material to be cloned and parameterized.
    Devin-Crawford committed May 8, 2023
    Configuration menu
    Copy the full SHA
    213d7b2 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Updated material assignment in stackup.

    AEDT throws a strange error when creating the patch.
    Devin-Crawford committed May 10, 2023
    Configuration menu
    Copy the full SHA
    6a63146 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Updated material assignment in stackup.

    AEDT throws a strange error when creating the patch.
    Devin-Crawford committed May 11, 2023
    Configuration menu
    Copy the full SHA
    0607e04 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Configuration menu
    Copy the full SHA
    a837528 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7e51cee View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1107514 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2023

  1. Configuration menu
    Copy the full SHA
    714f77b View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Configuration menu
    Copy the full SHA
    8e225f1 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. Configuration menu
    Copy the full SHA
    71dccfd View commit details
    Browse the repository at this point in the history

Commits on May 20, 2023

  1. Configuration menu
    Copy the full SHA
    1a0f653 View commit details
    Browse the repository at this point in the history
  2. Update Primitives._check_material

    Conductors with parametric conductivitiy were always returned as dielectrics.
    Devin-Crawford committed May 20, 2023
    Configuration menu
    Copy the full SHA
    0bcf156 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Configuration menu
    Copy the full SHA
    82c6c92 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5661e7f View commit details
    Browse the repository at this point in the history
  3. Material Lib evaluated value

    maxcapodi78 authored and maxcapodi78 committed May 22, 2023
    Configuration menu
    Copy the full SHA
    7a24dd8 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Configuration menu
    Copy the full SHA
    bf739bb View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. Update docstring

    filesystem.Scratch.copyfile()
    Devin-Crawford committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    f0b7f7a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    467f39e View commit details
    Browse the repository at this point in the history
  3. Add error handling to Scratch()

    FileNotFoundError if the path passed to Scratch() doesn't exist.
    Devin-Crawford committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    9af0140 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Add and improve comments.

    Added some comments and improved docstrings to help understand the code.
    Devin-Crawford committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    47bd8d8 View commit details
    Browse the repository at this point in the history
  2. Address 3275

    Method str_to_bool added to DataHandlers.py
    
    use map() to convert strings to Boolean when the diff pair arguments are passed to EditDiffPairs in Hfss in the method `set_differential_pair`
    Devin-Crawford committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    d1f2a88 View commit details
    Browse the repository at this point in the history
  3. Minor udpates.

    Adopted suggestions from @PipKat.
    Devin-Crawford committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    bc11306 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Merge remote-tracking branch 'origin/main' into update/ML_Example

    # Conflicts:
    #	examples/02-HFSS/Machine_learning_applied_to_Patch.py
    Devin-Crawford committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    d04a196 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    63a6dce View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a675e13 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2956f20 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Add Probe_Fed_Patch.py example

    Use the Stackup3D class. Note that the original ML Patch example had to be removed.
    Devin-Crawford committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    9323a1c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    984810c View commit details
    Browse the repository at this point in the history
  3. Grammar and syntax corrections.

    As suggested by @PipKat.
    Devin-Crawford committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    e1c5502 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    254b4fe View commit details
    Browse the repository at this point in the history
  5. Update method wave_port()

    use automatic port creation.
    Still wip
    Devin-Crawford committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    6b5e410 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Update method wave_port()

    - Added method _create_wave_port_from_face()
    - Updated Probe_Fed_Patch.py
    - Fixed error in AutoIdnetify boundary type.
    -
    Devin-Crawford committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    1799a5c View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2023

  1. Update method wave_port()

    - Check type of passed argument.
    - add import of pyaedt.modeler.cad
    Devin-Crawford committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    73d4f6e View commit details
    Browse the repository at this point in the history
  2. Update Boundary.py

    Correct error in AutoIdentify.
    Devin-Crawford committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    f9d39b5 View commit details
    Browse the repository at this point in the history
  3. Update Probe_Fed_Patch.py

    Plot S11.
    Devin-Crawford committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    a0ac370 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6e9d16b View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Update example

    Set non_graphical = False
    Version is 23.2.
    Devin-Crawford committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    34364e7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b571a4e View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Apply suggestions from code review

    Update grammar and syntax.
    
    Co-authored-by: Kathy Pippert <[email protected]>
    Devin-Crawford and PipKat authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    213e8d1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3093acf View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Update wave_port

    Trying to decipher the Hfss.wave_port() method. Adding comments and debugging.
    Devin-Crawford committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    f85516a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    43cc5b1 View commit details
    Browse the repository at this point in the history
  3. Hfss

    revert Hfss.wave_port() to current version in main branch
    Devin-Crawford committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    af65428 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Updated probe creation in Probe_Fed_Patch.py

    - also need to account for a FacePrimitive being passed to hfss._create_pec_cap
    Devin-Crawford committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    6e8e1ce View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    95622c9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8dd8b93 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Update duplicate_material

    Need to consider case when props is not passed.
    Devin-Crawford committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    d1b0250 View commit details
    Browse the repository at this point in the history
  2. Update Probe_Fed_Patch.py

    non_graphical=True
    Devin-Crawford committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    6398818 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cc1e888 View commit details
    Browse the repository at this point in the history
  4. Update str_to_bool

    Devin-Crawford committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    ed39dda View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2023

  1. Update comments

    -Update some docstrings.
    - Simplify syntax in probe fed patch face selection.
    - Add "small number" in test_20_HFSS.py to help test equivalence.
    Devin-Crawford committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    0c63d93 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1969055 View commit details
    Browse the repository at this point in the history
  3. Update Unit Tests

    Update test_20_HFSS.py
    Update some docstrings.
    - test_05_create_wave... still fails.
    Devin-Crawford committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    a2ceca7 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Configuration menu
    Copy the full SHA
    f501149 View commit details
    Browse the repository at this point in the history
  2. Merge from main

    - set non_graphical to True in Probe_Fed_Patch.py
    Devin-Crawford committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    96a619e View commit details
    Browse the repository at this point in the history
  3. Update unit test

    Update port test in test_20_HFSS.py
    Update docstring for stackup_3d.py
    Devin-Crawford committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    90d242c View commit details
    Browse the repository at this point in the history
  4. Update unit test

    Creation of "sheet1a_Port" in test_20_HFSS.py was non-physical. This has been fixed.
    Devin-Crawford committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    94ec15d View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Update pyaedt/hfss.py

    Co-authored-by: Kathy Pippert <[email protected]>
    Devin-Crawford and PipKat authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    6795f42 View commit details
    Browse the repository at this point in the history
  2. Update pyaedt/hfss.py

    Co-authored-by: Kathy Pippert <[email protected]>
    Devin-Crawford and PipKat authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    8741194 View commit details
    Browse the repository at this point in the history
  3. Update pyaedt/hfss.py

    Co-authored-by: Kathy Pippert <[email protected]>
    Devin-Crawford and PipKat authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    4be9c9a View commit details
    Browse the repository at this point in the history
  4. Update pyaedt/modeler/cad/Modeler.py

    Co-authored-by: Kathy Pippert <[email protected]>
    Devin-Crawford and PipKat authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    49e5572 View commit details
    Browse the repository at this point in the history
  5. Update pyaedt/modeler/cad/Modeler.py

    Co-authored-by: Kathy Pippert <[email protected]>
    Devin-Crawford and PipKat authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    d0c4dd1 View commit details
    Browse the repository at this point in the history
  6. Apply suggestions from code review

    update dosctrings based on review feedback.
    
    Co-authored-by: Kathy Pippert <[email protected]>
    Devin-Crawford and PipKat authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    9570958 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ba2bcfc View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Configuration menu
    Copy the full SHA
    f8f9c93 View commit details
    Browse the repository at this point in the history
  2. Fix minor bugs in Modeler

    Update to clone() and copy() had some minor errors.
    Devin-Crawford committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    76cdaaf View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Clean up stackup_3d.py

    Resolved inconsistencies in the way dielectric properties are handled.
    Devin-Crawford committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    0edf073 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Cleanup of Primitives3D.py

    Simplify assignment of sr for choke.
    Devin-Crawford committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    49f057b View commit details
    Browse the repository at this point in the history
  2. Fix typo in docstring.

    Devin-Crawford committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    6391b0f View commit details
    Browse the repository at this point in the history
  3. UT Fixes

    maxcapodi78 authored and maxcapodi78 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    a6cb168 View commit details
    Browse the repository at this point in the history
  4. fix evaluate_expression

    maxcapodi78 authored and maxcapodi78 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    99f715e View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Update pyaedt/modules/MaterialLib.py

    Co-authored-by: Kathy Pippert <[email protected]>
    Devin-Crawford and PipKat authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    8b70d6f View commit details
    Browse the repository at this point in the history
  2. Update pyaedt/generic/filesystem.py

    Co-authored-by: Maxime Rey <[email protected]>
    Devin-Crawford and MaxJPRey authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    c91f85e View commit details
    Browse the repository at this point in the history
  3. Update pyaedt/modules/MaterialLib.py

    Co-authored-by: Kathy Pippert <[email protected]>
    Devin-Crawford and PipKat authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    1ce79bc View commit details
    Browse the repository at this point in the history
  4. Update pyaedt/hfss.py

    Co-authored-by: Kathy Pippert <[email protected]>
    Devin-Crawford and PipKat authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    d791d38 View commit details
    Browse the repository at this point in the history
  5. Update pyaedt/hfss.py

    Co-authored-by: Kathy Pippert <[email protected]>
    Devin-Crawford and PipKat authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    472209e View commit details
    Browse the repository at this point in the history
  6. Update pyaedt/hfss.py

    Co-authored-by: Kathy Pippert <[email protected]>
    Devin-Crawford and PipKat authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    4f767cd View commit details
    Browse the repository at this point in the history
  7. Update pyaedt/hfss.py

    Co-authored-by: Kathy Pippert <[email protected]>
    Devin-Crawford and PipKat authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    313f85e View commit details
    Browse the repository at this point in the history
  8. Update pyaedt/generic/DataHandlers.py

    Co-authored-by: Kathy Pippert <[email protected]>
    Devin-Crawford and PipKat authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    51c17b0 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    34f9bcc View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    9fdf7a5 View commit details
    Browse the repository at this point in the history
  11. Update _unittest/test_20_HFSS.py

    Co-authored-by: Massimo Capodiferro <[email protected]>
    Devin-Crawford and maxcapodi78 authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    408e182 View commit details
    Browse the repository at this point in the history
  12. Update pyaedt/hfss.py

    Co-authored-by: Massimo Capodiferro <[email protected]>
    Devin-Crawford and maxcapodi78 authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    3c1e0be View commit details
    Browse the repository at this point in the history
  13. Update _unittest/test_20_HFSS.py

    Co-authored-by: Massimo Capodiferro <[email protected]>
    Devin-Crawford and maxcapodi78 authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    4f89c70 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    63e5f5d View commit details
    Browse the repository at this point in the history