better handling if users cancel file dlgs #3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't error out if users cancel a file dlg, just do "nothing"
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #3595 +/- ##
===========================================
+ Coverage 31.40% 80.98% +49.58%
===========================================
Files 178 178
Lines 61241 61241
===========================================
+ Hits 19230 49596 +30366
+ Misses 42011 11645 -30366 |
|
@jsalant22 What caused the change in the test result values? |
@myoung301 The interference tab was using PowerAtRx instead of normal EMI Margin. |
myoung301
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't error out if users cancel a file dlg, just do "nothing"