Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layout validation #3686

Merged
merged 26 commits into from
Oct 4, 2023
Merged

layout validation #3686

merged 26 commits into from
Oct 4, 2023

Conversation

hui-zhou-a
Copy link
Contributor

New class LayoutValidation for layout check.

        assert len(edbapp.nets["DDR4_DM3"].find_dc_short()) > 0
        edbapp.layout_validation.dc_shorts()

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@hui-zhou-a hui-zhou-a linked an issue Oct 2, 2023 that may be closed by this pull request
layout validation #3687
Closed
@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited
Loading

Codecov Report

Merging #3686 (d3fac5b) into main (c6620b4) will increase coverage by 0.01%.
The diff coverage is 91.62%.

@@            Coverage Diff             @@
##             main    #3686      +/-   ##
==========================================
+ Coverage   80.99%   81.01%   +0.01%     
==========================================
  Files         178      179       +1     
  Lines       61639    61729      +90     
==========================================
+ Hits        49926    50009      +83     
- Misses      11713    11720       +7

PipKat
PipKat reviewed Oct 2, 2023
View reviewed changes
pyaedt/edb.py Outdated Show resolved Hide resolved
@hui-zhou-a hui-zhou-a enabled auto-merge (squash) October 3, 2023 06:06
@hui-zhou-a hui-zhou-a merged commit 5653f90 into main Oct 4, 2023
10 of 11 checks passed
@hui-zhou-a hui-zhou-a deleted the refactoring branch October 4, 2023 12:49
@svandenb-dev svandenb-dev mentioned this pull request Feb 5, 2024
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat left review comments

@svandenb-dev svandenb-dev svandenb-dev approved these changes

@maxcapodi78 maxcapodi78 Awaiting requested review from maxcapodi78

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

layout validation
3 participants
@hui-zhou-a @svandenb-dev @PipKat