Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/issue 2630 #3690

Merged
merged 8 commits into from
Oct 3, 2023
Merged

Fix/issue 2630 #3690

merged 8 commits into from
Oct 3, 2023

Conversation

Samuelopez-ansys
Copy link
Member

Close #2630

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Oct 2, 2023
@Samuelopez-ansys
Copy link
Member Author

@ansys-reviewer-bot review

@ansys-reviewer-bot
Copy link
Contributor

Okay, I will trigger a review of your PR.

@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited
Loading

Codecov Report

Merging #3690 (dca8b3a) into main (d1e9ddb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3690   +/-   ##
=======================================
  Coverage   80.97%   80.97%           
=======================================
  Files         178      178           
  Lines       61597    61639   +42     
=======================================
+ Hits        49879    49914   +35     
- Misses      11718    11725    +7

MaxJPRey
MaxJPRey approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

DaveTwyman
DaveTwyman approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@DaveTwyman DaveTwyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New function works, tested in 2D and 3D for radially magnetised annular ring. Maxwell example to follow

@Samuelopez-ansys Samuelopez-ansys merged commit cbafc98 into main Oct 3, 2023
11 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/issue_2630 branch October 3, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansys-reviewer-bot ansys-reviewer-bot[bot] ansys-reviewer-bot[bot] left review comments

@MaxJPRey MaxJPRey MaxJPRey approved these changes

@DaveTwyman DaveTwyman DaveTwyman approved these changes

@maxcapodi78 maxcapodi78 Awaiting requested review from maxcapodi78

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Support for Cylindrical and Polar Coordinates in AEDT Materials
3 participants
@Samuelopez-ansys @MaxJPRey @DaveTwyman