EDB - Load amat material file from Aedt #3713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pyaedt/edb_core/edb_data/primitives_data.py
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov Report
@@ Coverage Diff @@
## main #3713 +/- ##
==========================================
+ Coverage 80.96% 81.02% +0.06%
==========================================
Files 178 179 +1
Lines 61595 61850 +255
==========================================
+ Hits 49872 50117 +245
- Misses 11723 11733 +10 |
hui-zhou-a
requested changes
Oct 5, 2023
pyaedt/edb_core/materials.py
Outdated
| @@ -788,3 +791,122 @@ def get_property_by_material_name(self, property_name, material_name): | |||
| else: | |||
| return property_box.ToDouble() | |||
| return False | |||
|
|
|||
| def load_material_from_aedt(self): | |||
There was a problem hiding this comment.
@svandenb-dev, I suggest to rename the method to
def load_sys_library(self):
pyaedt/edb_core/materials.py
Outdated
| @@ -788,3 +791,122 @@ def get_property_by_material_name(self, property_name, material_name): | |||
| else: | |||
| return property_box.ToDouble() | |||
| return False | |||
|
|
|||
| def load_material_from_aedt(self): | |||
| material_dict = self._read_materials() | |||
There was a problem hiding this comment.
@svandenb-dev please add docstring.
|
@svandenb-dev It will be nice to have a method load() to import .amat file. |
added 3 commits
October 6, 2023 12:34
add_material_from_aedt which expect an aedt material name load_material_from_amat which load all materials in amat current limitations: supports only materials with float value (no nonlinear materials and no formulas)
maxcapodi78
approved these changes
Oct 6, 2023
PipKat
reviewed
Oct 6, 2023
PipKat
reviewed
Oct 6, 2023
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading amat material in EDB