Validation rlc values #3745
Merged
Validation rlc values #3745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #3745 +/- ##
===========================================
+ Coverage 31.43% 81.07% +49.64%
===========================================
Files 179 180 +1
Lines 61935 61951 +16
===========================================
+ Hits 19468 50227 +30759
+ Misses 42467 11724 -30743 |
3 tasks
PipKat
reviewed
Oct 17, 2023
|
|
||
| @property | ||
| def type(self): | ||
| """Get type.""" |
There was a problem hiding this comment.
Properties should be defined as nouns. For this type property, the description should be "Type of ...." (Type of the base object?) We don't need to call out GET or SET usage in the description. If needed, an "Examples" section in the docstring could provide usage examples.)
PipKat
reviewed
Oct 17, 2023
| @@ -230,3 +230,21 @@ def illegal_net_names(self, fix=False): | |||
|
|
|||
| self._pedb._logger.info("Found {} illegal net names.".format(len(renamed_nets))) | |||
| return | |||
|
|
|||
| def illegal_rlc_values(self, fix=False): | |||
| """Find and fix rlc illegal values.""" | |||
There was a problem hiding this comment.
Suggested change
| """Find and fix rlc illegal values.""" | |
| """Find and fix RLC illegal values.""" |
Based on a search of the doc, it looks like we use RLC in all capital letters in descriptions.
svandenb-dev
approved these changes
Oct 18, 2023
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RLC can have no value from database. This feature is to add default values if it is missing.
In this PR, only inductors are check and fixed.