CI: Add edb label to labeler #3761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMoraisAnsys
requested review from
MaxJPRey,
maxcapodi78 and
Samuelopez-ansys
as code owners
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
|
@ansys-reviewer-bot review |
|
Okay, I will trigger a review of your PR. |
![ansys-reviewer-bot[bot]](https://avatars.githubusercontent.com/in/383621?s=60&v=4){kind=small}
.github/labeler.yml
Outdated
| - examples/01-HFSS3DLayout/EDB_in_3DLayout.py | ||
| - examples/05-Q3D/Q3D_from_EDB.py | ||
| - pyaedt/edb_core/** | ||
| - pyaedt/edb.py |
There was a problem hiding this comment.
Always include a newline at the end of the file. To fix this, add an empty line at the end of the labeler.yml file:
Suggested change
| - pyaedt/edb.py | |
| +- pyaedt/edb.py | |
Other than the newline at the end of the file, the patch seems fine, and adds new EDB categories for the labeler.
Codecov Report
@@ Coverage Diff @@
## main #3761 +/- ##
===========================================
+ Coverage 31.43% 81.07% +49.63%
===========================================
Files 179 179
Lines 61935 61935
===========================================
+ Hits 19468 50211 +30743
+ Misses 42467 11724 -30743 |
SMoraisAnsys
force-pushed
the
ci/update_labeler
branch
from
8408b4e
to
c4614cb
Compare
maxcapodi78
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Github workflow labeler to track changes related to
edb(based on specific modified files).This could me removed later on but would be of great help for the split between AEDT and EDB.