Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fillet chamfer docstring update #3768

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Fillet chamfer docstring update #3768

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2f7d48
fillet and chamfer docstring correction
anur7 Oct 18, 2023
bb67306
Merge branch 'main' into fillet_chamfer_docstring_update
anur7 Oct 19, 2023
f54bf44
Merge branch 'main' into fillet_chamfer_docstring_update
Samuelopez-ansys Oct 19, 2023
03f304a
Add UT
Samuelopez-ansys Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pyaedt/modeler/cad/elements3d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@

@pyaedt_function_handler()
def fillet(self, radius=0.1, setback=0.0):
"""Add a fillet to the selected edge.
"""Add a fillet to the selected edges in 3D/vertices in 2D.

Parameters
----------
Expand Down Expand Up @@ -98,7 +98,7 @@
if self._object3d.is3d:
edge_id_list = [self.id]
else:
self._object3d.logger.error("Filet is possible only on a vertex in 2D designs.")
self._object3d.logger.error("Fillet is possible only on a vertex in 2D designs.")

Check warning on line 101 in pyaedt/modeler/cad/elements3d.py

View check run for this annotation

Codecov / codecov/patch

pyaedt/modeler/cad/elements3d.py#L101 

Added line #L101 was not covered by tests
return False

vArg1 = ["NAME:Selections", "Selections:=", self._object3d.name, "NewPartsModelFlag:=", "Model"]
Expand All @@ -116,7 +116,7 @@

@pyaedt_function_handler()
def chamfer(self, left_distance=1, right_distance=None, angle=45, chamfer_type=0):
"""Add a chamfer to the selected edge.
"""Add a chamfer to the selected edges in 3D/vertices in 2D.

Parameters
----------
Expand Down
Loading