Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve model_depth getter setter #3771

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

gmalinve
Copy link
Collaborator

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #3771 (3841206) into main (c872cd3) will decrease coverage by 2.64%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3771      +/-   ##
==========================================
- Coverage   81.08%   78.44%   -2.64%     
==========================================
  Files         180      180              
  Lines       61956    61953       -3     
==========================================
- Hits        50239    48602    -1637     
- Misses      11717    13351    +1634     

Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) October 19, 2023 16:24
@Samuelopez-ansys Samuelopez-ansys merged commit 8713283 into main Oct 19, 2023
12 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the model_depth_getter_setter branch October 19, 2023 16:53
@gmalinve gmalinve linked an issue Oct 20, 2023 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModelDepth attribute breaks when ModelDepth is defined as expression in maxwell2d
3 participants