Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean create_region method #3783

Merged
merged 2 commits into from
Oct 23, 2023
Merged

clean create_region method #3783

merged 2 commits into from
Oct 23, 2023

Conversation

gmalinve
Copy link
Contributor

@gmalinve gmalinve commented Oct 23, 2023 •
edited by Samuelopez-ansys
Loading

Close #3784

@gmalinve gmalinve self-assigned this Oct 23, 2023
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@gmalinve gmalinve linked an issue Oct 23, 2023 that may be closed by this pull request
Clean create_region method #3784
Closed
@gmalinve gmalinve added the enhancement New features or code improvements label Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023 •
edited
Loading

Codecov Report

Merging #3783 (da99ea2) into main (99fb555) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3783      +/-   ##
==========================================
+ Coverage   81.07%   81.08%   +0.01%     
==========================================
  Files         180      180              
  Lines       61977    61975       -2     
==========================================
+ Hits        50246    50253       +7     
+ Misses      11731    11722       -9

Samuelopez-ansys
Samuelopez-ansys approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmalinve gmalinve merged commit 03ec960 into main Oct 23, 2023
12 checks passed
@gmalinve gmalinve deleted the clean_create_region_2d branch October 23, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samuelopez-ansys Samuelopez-ansys Samuelopez-ansys approved these changes

@tizianrot tizianrot Awaiting requested review from tizianrot

Assignees

@gmalinve gmalinve

Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean create_region method
2 participants
@gmalinve @Samuelopez-ansys