Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated LoadAEDT method to support array definition #3804

Merged
merged 20 commits into from
Oct 26, 2023

Conversation

Alberto-DM
Copy link
Collaborator

The AEDT parsing has been updated to get info about the 3d component array definition, which are not available through the API.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #3804 (e70c387) into main (103bdf1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3804      +/-   ##
==========================================
+ Coverage   81.09%   81.10%   +0.01%     
==========================================
  Files         180      180              
  Lines       62190    62227      +37     
==========================================
+ Hits        50431    50470      +39     
+ Misses      11759    11757       -2     

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add pragma no cover to the parser

pyaedt/generic/LoadAEDTFile.py Outdated Show resolved Hide resolved
pyaedt/generic/LoadAEDTFile.py Outdated Show resolved Hide resolved
pyaedt/generic/LoadAEDTFile.py Outdated Show resolved Hide resolved
pyaedt/generic/LoadAEDTFile.py Outdated Show resolved Hide resolved
pyaedt/generic/LoadAEDTFile.py Outdated Show resolved Hide resolved
pyaedt/generic/LoadAEDTFile.py Show resolved Hide resolved
pyaedt/generic/LoadAEDTFile.py Outdated Show resolved Hide resolved
pyaedt/generic/LoadAEDTFile.py Outdated Show resolved Hide resolved
pyaedt/generic/LoadAEDTFile.py Outdated Show resolved Hide resolved
pyaedt/generic/LoadAEDTFile.py Outdated Show resolved Hide resolved
pyaedt/generic/LoadAEDTFile.py Outdated Show resolved Hide resolved
@Samuelopez-ansys Samuelopez-ansys merged commit fd0636f into main Oct 26, 2023
12 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the adm_aedt_file_3dcomponents_cell branch October 26, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants