-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: remove potential vale warnings #3806
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Codecov Report
@@ Coverage Diff @@
## main #3806 +/- ##
==========================================
+ Coverage 81.08% 81.10% +0.02%
==========================================
Files 180 180
Lines 62140 62225 +85
==========================================
+ Hits 50384 50468 +84
- Misses 11756 11757 +1 |
@SMoraisAnsys Is this PR still a draft? |
Yes, I would like to be sure that everything is working as expected. |
I think the changes are working. Since I was not able to get any error, I added some strange sentence in the documentation to trigger vale and only this sentence got caught. Sentence added "Babedibabedibou rofl" Vale report :
I'll rewrite the history to only keep the changes of interest. |
At least since version 2.29.3 of vale, titles are also checked by vale. Thus, multiple warning started appearing due to non deterministic behavior when using multiple (differently-cased) entries for the same terme. The proposed solution consists in reworking the accept.txt file.
14cefd5
to
c911c0e
Compare
@SMoraisAnsys Could we merge? |
At least since version 2.29.3 of vale, titles are also checked by vale. Thus, multiple warning started appearing due to non deterministic behavior when using multiple (differently-cased) entries for the same terme.
The proposed solution consists in reworking the accept.txt file until no more warnings are generated.