Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve speed faces are loaded and ids are computed #3812

Merged
merged 35 commits into from
Oct 30, 2023
Merged

Improve speed faces are loaded and ids are computed #3812

merged 35 commits into from
Oct 30, 2023

Conversation

maxcapodi78
Copy link
Collaborator

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Merging #3812 (e131ddf) into main (853d374) will decrease coverage by 2.62%.
The diff coverage is 87.67%.

@@            Coverage Diff             @@
##             main    #3812      +/-   ##
==========================================
- Coverage   81.09%   78.48%   -2.62%     
==========================================
  Files         180      180              
  Lines       62225    62247      +22     
==========================================
- Hits        50464    48857    -1607     
- Misses      11761    13390    +1629

Samuelopez-ansys and others added 26 commits October 30, 2023 11:31
@Samuelopez-ansys @PipKat
Update pyaedt/modeler/cad/Primitives.py
3c92b91 
Co-authored-by: Kathy Pippert <[email protected]>
@Samuelopez-ansys @PipKat
Update pyaedt/modeler/cad/Primitives.py
34450b9 
Co-authored-by: Kathy Pippert <[email protected]>
@Samuelopez-ansys @PipKat
Update pyaedt/modeler/cad/Primitives.py
d00bf22 
Co-authored-by: Kathy Pippert <[email protected]>
@Samuelopez-ansys @PipKat
Update pyaedt/modeler/cad/Primitives.py
1b6d999 
Co-authored-by: Kathy Pippert <[email protected]>
@Samuelopez-ansys @PipKat
Update pyaedt/modeler/cad/Primitives.py
622d014 
Co-authored-by: Kathy Pippert <[email protected]>
@Samuelopez-ansys @PipKat
Update pyaedt/modeler/cad/Primitives.py
2ab580d 
Co-authored-by: Kathy Pippert <[email protected]>
@Samuelopez-ansys
Update pyaedt/modeler/cad/Primitives.py
05c6691
@Samuelopez-ansys
Update pyaedt/modeler/cad/Primitives.py
d96f66f
@Samuelopez-ansys @PipKat
Update pyaedt/modeler/cad/Primitives.py
cfdf9b2 
Co-authored-by: Kathy Pippert <[email protected]>
@Samuelopez-ansys @PipKat
Update pyaedt/modeler/cad/Primitives.py
a355298 
Co-authored-by: Kathy Pippert <[email protected]>
@Samuelopez-ansys @PipKat
Update pyaedt/modeler/cad/Primitives.py
a36fb55 
Co-authored-by: Kathy Pippert <[email protected]>
@Samuelopez-ansys @PipKat
Update pyaedt/modeler/cad/Primitives.py
724eb97 
Co-authored-by: Kathy Pippert <[email protected]>
@Samuelopez-ansys @PipKat
Update pyaedt/modeler/cad/Primitives.py
a1b166f 
Co-authored-by: Kathy Pippert <[email protected]>
@Samuelopez-ansys @PipKat
Update pyaedt/modeler/cad/Primitives.py
d6bd4b3 
Co-authored-by: Kathy Pippert <[email protected]>
@Samuelopez-ansys @PipKat
Update pyaedt/modeler/cad/Primitives.py
602b9ec 
Co-authored-by: Kathy Pippert <[email protected]>
@Samuelopez-ansys @PipKat
Update pyaedt/modeler/cad/Primitives.py
21be10b 
Co-authored-by: Kathy Pippert <[email protected]>
@Samuelopez-ansys @PipKat
Update pyaedt/modeler/cad/Primitives.py
2d26001 
Co-authored-by: Kathy Pippert <[email protected]>
@Samuelopez-ansys @PipKat
Update pyaedt/modeler/cad/Primitives.py
b839351 
Co-authored-by: Kathy Pippert <[email protected]>
@Samuelopez-ansys @PipKat
Update pyaedt/modeler/cad/Primitives.py
4e22300 
Co-authored-by: Kathy Pippert <[email protected]>
@Samuelopez-ansys
Update pyaedt/modeler/cad/Primitives.py
c2a25a8
@Samuelopez-ansys @PipKat
Update pyaedt/modeler/cad/Primitives.py
baaf756 
Co-authored-by: Kathy Pippert <[email protected]>
@Samuelopez-ansys @PipKat
Update pyaedt/modeler/cad/Primitives.py
ce2f0ff 
Co-authored-by: Kathy Pippert <[email protected]>
@Samuelopez-ansys
Merge branch 'main' into efficiency_improvements_object3d
0cc82e2 
# Conflicts:
#	pyaedt/modeler/cad/Modeler.py
@Samuelopez-ansys
Add Split method modification
f718109
@Samuelopez-ansys
Add docstring to create_region
4b959c9
@Samuelopez-ansys
Fix codacy
0ead0f2
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) October 30, 2023 11:35
@Samuelopez-ansys Samuelopez-ansys merged commit d19dc46 into main Oct 30, 2023
12 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the efficiency_improvements_object3d branch October 30, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat left review comments

@Samuelopez-ansys Samuelopez-ansys Samuelopez-ansys approved these changes

@gmalinve gmalinve Awaiting requested review from gmalinve

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxcapodi78 @PipKat @Samuelopez-ansys