Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files related to contributions. #3828

Merged
merged 4 commits into from
Nov 3, 2023
Merged

Add files related to contributions. #3828

merged 4 commits into from
Nov 3, 2023

Conversation

MaxJPRey
Copy link
Collaborator

@MaxJPRey MaxJPRey commented Oct 31, 2023

Adding a list of the main contributors.
Obviously names can be added and/or removed based on contributors will.

Thanks you all for your commitment and hard work.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@SMoraisAnsys
Copy link
Collaborator

@MaxJPRey Shouldn't we had every person present in here : https://github.com/ansys/pyaedt/graphs/contributors (excluding bots) ? The list could be split (if needed), e.g. in two parts : active collaborators and collaborators (not sure about the naming, something else might be more appropriate). Here is an example of what is performed in nodejs (https://github.com/nodejs/node/blob/main/README.md#current-project-team-members).

Note that in nodejs there is a notion of technical steering committee which is directly linked to the project governance. Thus, while working on this PR, why not adding some project governance information ? (e.g. GOVERNANCE.md)

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #3828 (73f41be) into main (fd22e24) will decrease coverage by 2.63%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3828      +/-   ##
==========================================
- Coverage   81.12%   78.50%   -2.63%     
==========================================
  Files         180      180              
  Lines       62306    62306              
==========================================
- Hits        50547    48913    -1634     
- Misses      11759    13393    +1634     

@MaxJPRey
Copy link
Collaborator Author

MaxJPRey commented Oct 31, 2023

@MaxJPRey Shouldn't we had every person present in here : https://github.com/ansys/pyaedt/graphs/contributors (excluding bots) ? The list could be split (if needed), e.g. in two parts : active collaborators and collaborators (not sure about the naming, something else might be more appropriate). Here is an example of what is performed in nodejs (https://github.com/nodejs/node/blob/main/README.md#current-project-team-members).

Note that in nodejs there is a notion of technical steering committee which is directly linked to the project governance. Thus, while working on this PR, why not adding some project governance information ? (e.g. GOVERNANCE.md)

@SMoraisAnsys I would just add those limited for now as they are active contributors.
Of course the list will evolved but I would rather have people asking to be added in this file before adding them.

For the governance file. I would be interested to investigate that.
We would need some approval -e.g. legal- before to proceed.
Please bring the topic in the next team meeting.

Copy link
Contributor

@Devin-Crawford Devin-Crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaxJPRey MaxJPRey enabled auto-merge (squash) November 3, 2023 12:06
@MaxJPRey MaxJPRey merged commit eca7ad3 into main Nov 3, 2023
11 of 12 checks passed
@MaxJPRey MaxJPRey deleted the doc/contributing branch November 3, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants