-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create port, probe enhancement #3833
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
for more information, see https://pre-commit.ci
…te_probe_advanced
Codecov Report
@@ Coverage Diff @@
## main #3833 +/- ##
==========================================
+ Coverage 81.13% 81.14% +0.01%
==========================================
Files 180 180
Lines 62301 62293 -8
==========================================
+ Hits 50549 50550 +1
+ Misses 11752 11743 -9 |
for more information, see https://pre-commit.ci
…te_probe_advanced
for more information, see https://pre-commit.ci
@ring630 @svandenb-dev @SMoraisAnsys Could we merge this PR? |
@Samuelopez-ansys I don't have anything to add, so I will merge it once it is reviewed and approved. |
1, property terminal -> method get_terminal(create_new_terminal). This is to improve usability before people start to use terminal property.
2, bug fix. PointTerminal.location
3, Refactor. boundary_type, terminal_type.
4, versatile methods to create ports, probes, sources between terminals