Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create port, probe enhancement #3833

Merged
merged 15 commits into from
Nov 8, 2023
Merged

create port, probe enhancement #3833

merged 15 commits into from
Nov 8, 2023

Conversation

hui-zhou-a
Copy link
Contributor

@hui-zhou-a hui-zhou-a commented Nov 1, 2023

1, property terminal -> method get_terminal(create_new_terminal). This is to improve usability before people start to use terminal property.

2, bug fix. PointTerminal.location

3, Refactor. boundary_type, terminal_type.

4, versatile methods to create ports, probes, sources between terminals

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the edb label Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #3833 (2c4e276) into main (4abc8f5) will increase coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 96.42%.

❗ Current head 2c4e276 differs from pull request most recent head 8ebad4f. Consider uploading reports for the commit 8ebad4f to get more accurate results

@@            Coverage Diff             @@
##             main    #3833      +/-   ##
==========================================
+ Coverage   81.13%   81.14%   +0.01%     
==========================================
  Files         180      180              
  Lines       62301    62293       -8     
==========================================
+ Hits        50549    50550       +1     
+ Misses      11752    11743       -9     

@hui-zhou-a hui-zhou-a linked an issue Nov 1, 2023 that may be closed by this pull request
@Samuelopez-ansys
Copy link
Member

@ring630 @svandenb-dev @SMoraisAnsys Could we merge this PR?

@hui-zhou-a
Copy link
Contributor Author

@ring630 @svandenb-dev @SMoraisAnsys Could we merge this PR?

@Samuelopez-ansys I don't have anything to add, so I will merge it once it is reviewed and approved.

pyaedt/edb.py Outdated Show resolved Hide resolved
pyaedt/edb.py Outdated Show resolved Hide resolved
pyaedt/edb.py Show resolved Hide resolved
pyaedt/edb.py Show resolved Hide resolved
pyaedt/edb.py Show resolved Hide resolved
pyaedt/edb.py Show resolved Hide resolved
pyaedt/edb.py Show resolved Hide resolved
@hui-zhou-a hui-zhou-a enabled auto-merge (squash) November 8, 2023 08:46
@hui-zhou-a hui-zhou-a merged commit d6df01f into main Nov 8, 2023
11 checks passed
@hui-zhou-a hui-zhou-a deleted the create_probe_advanced branch November 8, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add EdbSiwave.create_source_between_pin_and_layer
4 participants